Repository navigation
[HDX-4664] Use a dedicated Replicated otel database for fresh installs - #286
SpencerTorres wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 23828af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deep ReviewScope: PR #286 ✅ No critical issues found. The template logic is sound: the ClickHouse spec is 🟡 P2 -- recommended
Reviewers (6): correctness, testing, maintainability, project-standards, reliability, adversarial. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. |
388fd75 to
0db83f3
Compare
Helm template coverage
Uncovered detailscharts/clickstack/templates/NOTES.txtUncovered lines: none Uncovered branches: 38:default:fallback charts/clickstack/templates/_helpers.tplUncovered lines: 17 Uncovered branches: 163:range:empty, 165:range:empty, 16:if:true, 203:and(2):false, 234:or(1):true, 287:default:fallback, 297:default:fallback, 298:or(1):true, 314:if:false, 444:range:empty, 465:range:empty, 46:range:empty, 492:default:fallback, 528:default:fallback charts/clickstack/templates/additional-manifests.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/clickhouse/cluster.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/clickhouse/keeper.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/configmap.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/cronjob-check-alerts.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/dashboard-configmap.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/dashboard-provisioner-rbac.yamlUncovered lines: none Uncovered branches: 41:range:empty, 61:range:empty charts/clickstack/templates/hyperdx/deployment.yamlUncovered lines: none Uncovered branches: 122:default:fallback, 132:default:fallback, 197:default:fallback, 202:with:empty, 21:with:empty, 27:default:fallback, 42:if:false, 43:with:empty charts/clickstack/templates/hyperdx/hpa.yamlUncovered lines: none Uncovered branches: 17:with:empty charts/clickstack/templates/hyperdx/ingress.yamlUncovered lines: none Uncovered branches: 16:with:empty, 36:if:false, 41:range:empty, 46:range:empty, 49:with:empty, 55:range:empty, 59:range:empty, 60:or(2):true, 60:or(3):true charts/clickstack/templates/hyperdx/networkpolicy.yamlUncovered lines: none Uncovered branches: 12:with:empty charts/clickstack/templates/hyperdx/pdb.yamlUncovered lines: none Uncovered branches: 11:with:empty charts/clickstack/templates/hyperdx/secret.yamlUncovered lines: none Uncovered branches: 2:or(2):true, 2:or(3):true charts/clickstack/templates/hyperdx/service.yamlUncovered lines: none Uncovered branches: 10:with:empty, 15:default:fallback charts/clickstack/templates/hyperdx/serviceaccount.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/mongodb/community.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/mongodb/password-secret.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/otel-collector/custom-config.yamlUncovered lines: none Uncovered branches: none |
Summary
Fresh installs with the bundled ClickHouse now use a dedicated
oteldatabase, created by the collector's migration as Replicated withReplicated*tables. Existing installs keep their current database and engines.Draft until upgraded HyperDX collector ships (ClickHouse/ClickStack#3309) (adds the replicated migration) and the Update App Version PR for 2.x.x is merged. With the current collector image,
otelwould be created with plain engines.How it works
otelotelhelm upgradedefault)helm templateupgradedefaultvia fallbackdefaultdefaultUpgrades are detected with a
lookupof the existingclickstack-configConfigMap. Renders without cluster access can't see it, so the collector falls back todefaultwhen it finds existing ClickStack tables there.Known limitations
helm templateupgrade, teams created later get default sources onotel. PinHYPERDX_OTEL_EXPORTER_CLICKHOUSE_DATABASE: "default"to avoid this (documented in UPGRADE.md).Test Plan
helm unittest(270 tests) andhelm lint